Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zwhitchcox
Copy link

Add exclusive include to make sure people know how they can include only certain files. This is extremely useful if you're trying to debug a certain file.

I also changed one of the examples on line 340, because the options have to be specific before the main script, or they will not be included.

And I added a line to the troubleshooting file to make sure users don't make the same mistake.

close #527

Add exclusive include to make sure people know how they can include only certain files. This is extremely useful if you're trying to debug a certain file.

I also changed one of the examples on line 340, because the options have to be specific before the main script, or they will not be included.
@3y3
Copy link
Member

3y3 commented Jan 18, 2015

Hello, @zwhitchcox , are you sure that you don't have any problems with node-debug ... --hidden=... app ?
This question is relative to #498

@zwhitchcox
Copy link
Author

Actually, it has stopped working since the last commit, I believe

@3y3
Copy link
Member

3y3 commented Jan 18, 2015

I opened a PR #530
Can you please confirm, that it fixes a bug.

@zwhitchcox
Copy link
Author

runnin' like a dream!

@@ -337,7 +350,7 @@ $ node-debug --web-host 127.0.0.2 app
```
Pass `--option=value` to debugging process:
```
$ node-debug app --option value
$ node-debug --option value app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks suspicious to me. IIRC the arguments before the script file are processed by Node Inspector and/or node-debug. Only the arguments after the script file are passed to the debugged node process. @3y3: am I wrong?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU, this example is illustrating how to pass arguments to the process being debugged. The proposed version shows how to pass arguments to Node Inspector instead, which is already covered by the previous examples with -p and --web-host.

Having said that, this is IMO a good place where to include the note "Make sure you put the Node Inspector options before the main script argument."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm wrong here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to hide all files except the ones in a specific directory
3 participants