ForceSet fix so the module can be used with newer Node JS #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, what is preventing this from getting merged (aside from the failing build)? This seems to resolve #468 which gets regular attention it seems to me. Is merging this a risk of introducing regressions elsewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using with newer Node where ForceSet is removed causes errors with missing symbols like this one on Mac:
dyld: lazy symbol binding failed: Symbol not found: __ZN2v86Object8ForceSetENS_5LocalINS_5ValueEEES3_NS_17PropertyAttributeE
Error fixed by strictly using Nan::ForceSet everywhere.