Add options param to Library func with option to disable appending of library extension #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… library extension Fixes node-ffi#257
benhutchins
force-pushed
the
feature/bh/disable-append-extension
branch
from
0044546
to
64f9707
Compare
|
It appears these failures are due to |
|
👍 In certain scenarios it is necessary to load libraries with non-standard file extensions |
|
@TooTallNate What do you think of this proposal? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257
See past tickets reflecting this #38, PR #39, #47
The only system I can tell this seems to be needed on is Mac, which doesn't include an extension in more of their system libraries. It seems difficult to write a test that verifies this reliably without doing a bit of additional refactoring.