-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple config for diffrent branch in one process. #464
Conversation
- Supported by configrc.json file to read NODE_CONFIG_DIR. - Support configuration defined in configrc.json. Strategy - different module `config` read different config folder. - __dirname folder is first to find, then recursively finding until root directory. Usage - Node gray deploy, A/B forks need their own config, but don’t change their code. So A/B can use their directory’s config to resolve this problem.
What is this solving? Was there a discussion of this that I missed? |
This breaks our Travis CI tests |
Sorry, it's because of using
Also support {
"NODE_CONFIG_DIR": "./branches/a/server/config",
"config": {
"assetDir": "./branches/a/static",
"serverDir": "./branches/a/server"
}
} Test |
So to make sure I understand your situation: You've got a big project, one where part of it might depend on a project that uses This sounds a lot like #225 and #226 Have you read through those related issues? |
@markstos Yeah, had readed them, almost the same problem, except one difference: the submodules are the current repository itself, but different commits. So the The usage of
Each submodule has its own configurations directory, own node_modules which contains |
I'm closing this in favor of #670, which offers a clearer vision of how to address submodule support. I'm not sure #670 addresses having different versions of configuration for different versions of the same module, but no else but the author has expressed on this PR since 2018, so it is apparently an edge case. |
Add configrc.* file to read config directory;
configrc.* file can support multiple config for diffrent branch in one process.