make the parser mode configurable (fastest, smallest, standard) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a fantastic idea. I was about to implement something similar but thought I'd check to see if someone already had a pull request for this exact configuration option. |
|
Another option might be to just make the $parser property protected instead of private. That way anyone could easily extend Extension and set $parser using one of the other Factory static methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WyriHaximus/HtmlCompress comes with several presets, currently the smallest scheme is used.
This can cause problems with inline javascript, inline js is compressed too and some of the minifiers are producing invalid js code.
The fastest/standard modes are more reliable.