Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAQ v1 fixes + initial OpenAQ v2 reader #141

Draft
wants to merge 55 commits into
base: develop
Choose a base branch
from
Draft

OpenAQ v1 fixes + initial OpenAQ v2 reader #141

wants to merge 55 commits into from

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Oct 26, 2023

Closes #130 #122

@zmoon
WIP: new reader for single openaq-fetches file
2402338
@zmoon
Trying a larger file from Jordan's day
4401a6a 
has "nox" and "pm1" with ug m-3 units
@zmoon
WIP: revising OPENAQ class
2f6c164
@zmoon
WIP: want to try going through the JSON with Python
375d72a 
and constructing the arrays or dicts for pandas that way
@zmoon
Python processing reader mostly works
c06e8f2
@zmoon
Merge remote-tracking branch 'noaa/develop' into openaq
03a99e9
@zmoon
Get first attribution
10f0402
@zmoon
Trying out getting attribution with larger dataset
5b20db8
@zmoon
Trying out OpenAQ API v2
1af59cb
@zmoon
todo
0657d3e
@zmoon
Experimenting with smaller (finishable) queries
157be3c
@zmoon
NOx ppm; disable prints (for prog bar)
36c4189
@zmoon
The species Jordan wants
3ff4cd6
@zmoon
Pass API key
b096dd7
@zmoon
Merge remote-tracking branch 'noaa/develop' into openaq
af05335
@zmoon
Currently converting NOx to ppmv
d41c645
@zmoon
WIP
7a69d06
@zmoon
Testing get-locations
f91a7c5
@zmoon
Locations as df
4ff270e
@zmoon
notes
af86394
@zmoon
Get parameters list
d59e647
@zmoon
Trying lat/lon box method
919bb91 
Barry's idea
@zmoon
Towards working add-data fn
8510ff5
@zmoon
Initial search radius(es) option
97b68de
@zmoon
docstring work
3ab3102
@zmoon
No time split option; more input validation
5cc7d08
@zmoon
country option
916d7de
@zmoon
consistency
6a8107b
@zmoon
Use logger
e86d927
@zmoon
fix
8a11fe3
@zmoon zmoon added this to the v0.3 milestone Oct 26, 2023
@zmoon zmoon mentioned this pull request Oct 26, 2023
Open
4 tasks
@zmoon zmoon mentioned this pull request Oct 26, 2023
Merged
@zmoon
Copy link
Member Author

zmoon commented Oct 26, 2023

AQS unreachable again.

And for 3.8, additionally getting:

FAILED tests/test_openaq.py::test_openaq_first_date - TypeError: openssl_sha1() takes at most 1 argument (2 given)
FAILED tests/test_openaq.py::test_openaq_long_fmt - TypeError: openssl_sha1() takes at most 1 argument (2 given)
FAILED tests/test_openaq.py::test_openaq_2023 - TypeError: openssl_sha1() takes at most 1 argument (2 given)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zmoon