Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wait for #4395] github-action: post-build follow-up tests #4399

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

myungjoo
Copy link
Member

@myungjoo myungjoo commented Feb 1, 2024

This includes follow-up tests, which test other software packages
directly depending on NNStreamer.

  • Android ML-API
  • Ubuntu app test
  • Tizen ML-API test
  • Tizen ML Agent test

Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 1, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #4399. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@myungjoo myungjoo changed the title github-action: post-build follow-up tests [Wait for #4395] github-action: post-build follow-up tests Feb 1, 2024
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 1, 2024

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

1 similar comment
@taos-ci
Copy link
Collaborator

taos-ci commented Feb 1, 2024

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@myungjoo myungjoo force-pushed the drop.taos-ci.pr.minors branch 4 times, most recently from f71209e to f70492b Compare February 2, 2024 03:24
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 2, 2024

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/4399-202402021358160.87051510810852-2bc4d4224763b39d08df3b157fbf09fdaf27ed4d/.

@myungjoo myungjoo force-pushed the drop.taos-ci.pr.minors branch 9 times, most recently from f0be9e7 to 9095058 Compare February 5, 2024 08:36
@taos-ci
Copy link
Collaborator

taos-ci commented Feb 5, 2024

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/4399-202402051736200.81511998176575-90950587035531eb2ba43e9b8e7e96c48e205cc8/.

@myungjoo myungjoo force-pushed the drop.taos-ci.pr.minors branch 2 times, most recently from c51d97a to 1050abe Compare February 5, 2024 09:51
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo force-pushed the drop.taos-ci.pr.minors branch 5 times, most recently from f8ae89f to 820005a Compare February 6, 2024 03:29
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo force-pushed the drop.taos-ci.pr.minors branch 2 times, most recently from 3f097cb to 6de05d5 Compare February 7, 2024 01:04
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo force-pushed the drop.taos-ci.pr.minors branch 10 times, most recently from 212c1fd to 03c113b Compare February 7, 2024 07:05
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo force-pushed the drop.taos-ci.pr.minors branch 2 times, most recently from c8bcddb to ad42cd8 Compare February 7, 2024 08:12
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

Occasionally, in github-action CI, datareposink.writeFlexibleTensors_n
fails due to synchronization errors:

```
[ RUN      ] datareposink.writeFlexibleTensors_n
../tests/nnstreamer_datarepo/unittest_datareposink.cc:570: Failure
Expected: (file_info) != (nullptr), actual: NULL vs (nullptr)
[  FAILED  ] datareposink.writeFlexibleTensors_n (173 ms)
```

It happens when the pipeline is set NULL before the file 'flexible.data'
is writtn within the pipeline.
Allow some time (0.1s) before setting it NULL.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
This includes follow-up tests, which test other software packages
directly depending on NNStreamer.
- Android ML-API
- Ubuntu app test
- Tizen ML-API test
- Tizen ML Agent test

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@myungjoo myungjoo force-pushed the drop.taos-ci.pr.minors branch 6 times, most recently from 1cb3614 to 9dd09fd Compare February 8, 2024 03:15
Android ML API build test.

We can finally drop TAOS-CI from nnstreamer after this.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Copy link

Watermelon AI Summary

This pull request addresses a synchronization issue in the NNStreamer's data repository handling, adds a suite of post-build follow-up tests for dependent software packages across multiple platforms, and works on continuous integration improvements for the Android ML API and Ubuntu application builds.

nnstreamer is an open repo and Watermelon will serve it for free.
🍉🫶

Fix permission issues of video loopback test.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants