New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dist/Tizen: Enable ncnn tensor_filter sub-plugin @open sesame 03/06 15:00 #4379
base: main
Are you sure you want to change the base?
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #4379. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
Releasing of NCNN is currently WiP. |
cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/4379-202401111318270.17357611656189-8575b45ff9b6a12267cb42fd6b7da37187bd2258/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NCNN is required to be published on Tizen. |
Watermelon AI SummaryThis Pull Request integrates a newly released ncnn neural network component into Tizen's tensor filtering system, enhancing its machine learning capabilities, though it currently skips actual run testing. GitHub PRs
nnstreamer is an open repo and Watermelon will serve it for free. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue 1: All positive unit TCs failed.
Issue 2: Negative TCs do not have the postfix, _n
.
Issue 1 of TC 1/2 is caused by gstreamer version mismatch with your assumptions. |
@myungjoo Well, NCNN has been published, and I almost forgot about this PR. |
This patch appends the '_n' postfix to the negative TCs' ID numbers. Signed-off-by: Wook Song <wook16.song@samsung.com>
As ncnn packages are released on the Tizen public repository, this patch enables the ncnn sub-plugin for the tensor filter in Tizen. Signed-off-by: Wook Song <wook16.song@samsung.com>
This trivial issue has been resolved. |
The two failed TCs involve several sub-issues. I will summarize them and post them on the Issues. Merging them may take some time. |
You may simple check gstreamer version (or property availability with gst-inspect) at the test script to skip this instance if it's old. |
As ncnn packages are released on the Tizen public repository,
this patch enables the ncnn sub-plugin for the tensor filter in Tizen.
Signed-off-by: Wook Song wook16.song@samsung.com
Self evaluation: