Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dist/Tizen: Enable ncnn tensor_filter sub-plugin @open sesame 03/06 15:00 #4379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wooksong
Copy link
Member

As ncnn packages are released on the Tizen public repository,
this patch enables the ncnn sub-plugin for the tensor filter in Tizen.

Signed-off-by: Wook Song wook16.song@samsung.com

Self evaluation:

  1. Build test: [*]Passed [ ]Failed [ ]Skipped
  2. Run test: [ ]Passed [ ]Failed [*]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 11, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #4379. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@wooksong
Copy link
Member Author

Releasing of NCNN is currently WiP.

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 11, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/4379-202401111318270.17357611656189-8575b45ff9b6a12267cb42fd6b7da37187bd2258/.

Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wooksong
Copy link
Member Author

Watermelon AI Summary

This Pull Request integrates a newly released ncnn neural network component into Tizen's tensor filtering system, enhancing its machine learning capabilities, though it currently skips actual run testing.
Please create an account on Watermelon to get better results.

GitHub PRs

nnstreamer is an open repo and Watermelon will serve it for free.
🍉🫶

@wooksong wooksong changed the title Dist/Tizen: Enable ncnn tensor_filter sub-plugin Dist/Tizen: Enable ncnn tensor_filter sub-plugin @open sesame 15:00 Mar 6, 2024
@wooksong wooksong changed the title Dist/Tizen: Enable ncnn tensor_filter sub-plugin @open sesame 15:00 Dist/Tizen: Enable ncnn tensor_filter sub-plugin @open sesame 03/06 15:00 Mar 6, 2024
@myungjoo
Copy link
Member

[ 556s] [FAILED] nnstreamer_filter_ncnn (6 passed among 9 cases)

Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 1: All positive unit TCs failed.
Issue 2: Negative TCs do not have the postfix, _n.

@myungjoo
Copy link
Member

Issue 1 of TC 1/2 is caused by gstreamer version mismatch with your assumptions.
Older GStreamer (e.g., 1.14) does not have num-buffers property in the imagefreeze element.

@wooksong
Copy link
Member Author

Issue 1: All positive unit TCs failed.
Issue 2: Negative TCs do not have the postfix, _n.
Issue 1 of TC 1/2 is caused by gstreamer version mismatch with your assumptions. Older GStreamer (e.g., 1.14) does not have num-buffers property in the imagefreeze element.

@myungjoo Well, NCNN has been published, and I almost forgot about this PR.
Even though I was only in charge of the packaging part (the implementation of the filter and TCs was the work of the SNU students), I will take a look as you commented. Thanks!

This patch appends the '_n' postfix to the negative TCs' ID numbers.

Signed-off-by: Wook Song <wook16.song@samsung.com>
As ncnn packages are released on the Tizen public repository, this patch
enables the ncnn sub-plugin for the tensor filter in Tizen.

Signed-off-by: Wook Song <wook16.song@samsung.com>
@wooksong
Copy link
Member Author

Issue 2: Negative TCs do not have the postfix, _n.

This trivial issue has been resolved.

@wooksong
Copy link
Member Author

Issue 1 of TC 1/2 is caused by gstreamer version mismatch with your assumptions. Older GStreamer (e.g., 1.14) does not have num-buffers property in the imagefreeze element.

The two failed TCs involve several sub-issues. I will summarize them and post them on the Issues. Merging them may take some time.

@myungjoo
Copy link
Member

myungjoo commented Apr 3, 2024

You may simple check gstreamer version (or property availability with gst-inspect) at the test script to skip this instance if it's old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants