Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memleak fix: gst_tensor_meta_info_parse_memory usage @open saseme 12/06 19:00 #4238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

memleak fix: gst_tensor_meta_info_parse_memory usage @open saseme 12/06 19:00 #4238

wants to merge 1 commit into from
+38 −36

Conversation

myungjoo
Copy link
Member

@myungjoo myungjoo commented Sep 6, 2023 •
edited

The input GstMemory given to gst_tensor_meta_info_parse_memory should be deallocated (unref) by the caller.

There are a few elements that do not call unref it, which often create a huge memory leak with converter/filter.

Leave a Doxygen note that the caller should unref it, too.

Another issue is that we have situation like

  1. collect_pad->buf is set
  2. someone gets the buf and replace it with buf2
  3. collect_pad->buf is unchanged and becomes dangling.
    Thus, let 2. not replace it, but update it.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 6, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #4238. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@myungjoo myungjoo mentioned this pull request Sep 6, 2023
Merged
@taos-ci
Copy link
Collaborator

taos-ci commented Sep 6, 2023

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/4238-202309061711010.86985611915588-ef35386a42d6d42d15d2cda9f7707426fd68d464/.

@myungjoo myungjoo added bug Something isn't working DO NOT MERGE labels Sep 6, 2023
@taos-ci
Copy link
Collaborator

taos-ci commented Sep 6, 2023

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/4238-202309061736500.80518698692322-ea87f67240f6803b1192ebfd9cfd0ba791195883/.

@myungjoo myungjoo changed the title memleak fix: gst_tensor_meta_info_parse_memory usage memleak fix: gst_tensor_meta_info_parse_memory usage @open saseme 10/11 08:07 Oct 10, 2023
@myungjoo myungjoo force-pushed the fix/gst_mem_leak branch 2 times, most recently from 726df0f to 75949ed Compare October 11, 2023 11:55
@myungjoo myungjoo removed the bug Something isn't working label Oct 11, 2023
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 11, 2023

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/4238-202310112055590.52832698822021-75949edbf4305c66e02643616b165c05108f18c3/.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 11, 2023

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/4238-202310112123050.62749004364014-3ad9acda4823c30e051ad30e306be2df704f30aa/.

@myungjoo
memleak fix: gst_tensor_meta_info_parse_memory usage
11302ea 
The input GstMemory given to gst_tensor_meta_info_parse_memory
should be deallocated (unref) by the caller.

There are a few elements that do not call unref it, which
often create a huge memory leak with converter/filter.

Leave a Doxygen note that the caller should unref it, too.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@myungjoo myungjoo changed the title memleak fix: gst_tensor_meta_info_parse_memory usage @open saseme 10/11 08:07 memleak fix: gst_tensor_meta_info_parse_memory usage @open saseme 12/06 19:00 Dec 6, 2023
@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@niley7464 niley7464 Awaiting requested review from niley7464 niley7464 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myungjoo @taos-ci