Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] filter:tf-lite2-custom error detector #3730

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] filter:tf-lite2-custom error detector #3730

wants to merge 2 commits into from

Conversation

myungjoo
Copy link
Member

  1. let users configure the location of libtensorflow2-lite-custom.so
  2. detect if it's properly loaded and emit proper error messages if failed.

Addressing #3717

Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Apr 19, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3730. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Apr 19, 2022

:octocat: cibot: @myungjoo, apptest could not be completed. To find out the reasons, please go to http://nnstreamer.mooo.com//nnstreamer/ci/repo-workers/pr-checker/3730-202204191958000.13923597335815-bec354e520586c42c7fa9b85cdd6c0751abe3d51

@taos-ci
Copy link
Collaborator

taos-ci commented Apr 19, 2022

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3730-202204191958000.13923597335815-bec354e520586c42c7fa9b85cdd6c0751abe3d51/.

@myungjoo myungjoo mentioned this pull request Apr 20, 2022
Merged
@myungjoo myungjoo force-pushed the fix/3713_detect branch 2 times, most recently from 3819f5a to 7d144e2 Compare April 21, 2022 10:22
@myungjoo myungjoo force-pushed the fix/3713_detect branch 2 times, most recently from e408dcb to 3f8eebb Compare May 3, 2022 10:38
@taos-ci
Copy link
Collaborator

taos-ci commented May 3, 2022

:octocat: cibot: @myungjoo, apptest could not be completed. To find out the reasons, please go to http://ci.nnstreamer.ai//nnstreamer/ci/repo-workers/pr-checker/3730-202205031938520.94306111335754-3f8eebb0f980cd93c7540feeac4fc2159dfcd4a1

@taos-ci
Copy link
Collaborator

taos-ci commented May 3, 2022

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/3730-202205031938520.94306111335754-3f8eebb0f980cd93c7540feeac4fc2159dfcd4a1/.

@myungjoo myungjoo added for-next Will not be merged in "main" branch until the next release. and removed for-next Will not be merged in "main" branch until the next release. labels Sep 22, 2022
@myungjoo
[WIP] filter:tf-lite2-custom error detector
8674644 
1. let users configure the location of libtensorflow2-lite-custom.so
2. detect if it's properly loaded and emit proper error messages if failed.

Addressing nnstreamer#3717

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@myungjoo
subplugin-infra: add param for get_subplugin() (i/f only)
61ec316 
In order to let tensor-filter::tensorflow2-lite accept custom tf-lite
binary located at an arbitrary directory, get_subplugin()
should accept such directory for its search paths.

Implmentation should follow soon.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Sep 29, 2022

:octocat: cibot: @myungjoo, apptest could not be completed. To find out the reasons, please go to http://ci.nnstreamer.ai//nnstreamer/ci/repo-workers/pr-checker/3730-202209290930400.48280811309814-61ec316057e3d30a1a25f96b279bcace82b47240

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 29, 2022

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer/ci/repo-workers/pr-checker/3730-202209290930400.48280811309814-61ec316057e3d30a1a25f96b279bcace82b47240/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon will be requested when the pull request is marked ready for review jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you will be requested when the pull request is marked ready for review again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung will be requested when the pull request is marked ready for review jaeyun-jung is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong will be requested when the pull request is marked ready for review wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang will be requested when the pull request is marked ready for review gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 will be requested when the pull request is marked ready for review anyj0527 is a code owner

@songgot songgot Awaiting requested review from songgot songgot will be requested when the pull request is marked ready for review songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu will be requested when the pull request is marked ready for review jihochu is a code owner

@niley7464 niley7464 Awaiting requested review from niley7464 niley7464 will be requested when the pull request is marked ready for review niley7464 is a code owner

@yeonykim2 yeonykim2 Awaiting requested review from yeonykim2 yeonykim2 will be requested when the pull request is marked ready for review yeonykim2 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myungjoo @taos-ci