Fix CMAES._get_sigma #103
Open
Fix CMAES._get_sigma #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NaturalGradient what do you think? |
NaturalGradient
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
this change is sensible in terms of type consistency, but the original casting to float described in #101 is not problematic as, in the case of CMA-ES, sigma corresponds to the step-size and is always a single scalar. Nevertheless this change is sensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #101
Do not cast sigma to a builtin float but keep it as a torch.Tensor. Now the return type also matches with the superclass.