Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Task Planning app #138

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Bharath-KumarReddy
Copy link

Task_planning_app
Login, sign up with fire_base authentication.

Each and every user have their own tasks or plans to do.
In this after user logged in he can see his plans if already present, if not he can plan or create his tasks, and he can update, he can also delete his tasks or plans after he done with his each task.

I had changed the package name to github.nisrulz.todo_app

once please check , kindly inform for any modifications hacktoberfest_23 : )

@nisrulz
Copy link
Owner

nisrulz commented Oct 15, 2023

@Bharath-KumarReddy Thank you for your contribution. I will review it this week :)

@nisrulz nisrulz changed the title taskplanning_app Example: Task Planning app Oct 15, 2023
@nisrulz
Copy link
Owner

nisrulz commented Oct 15, 2023

@Bharath-KumarReddy if you can include a screenshot/video in your PR description it makes the PR more useful for review.

Also note how other contributors write their description. You will learn a lot as well as write better PR descriptions. Here is a PR #130 that you can use for reference and example, of how a good PR description looks like.

@nisrulz
Copy link
Owner

nisrulz commented Oct 17, 2023

I have taken a quick look at your PR code @Bharath-KumarReddy . Take a look at my commit here: a977376

@Bharath-KumarReddy
Copy link
Author

here is the demo of firebase_todo_app [taskplanning]

firebase_todo.mp4

@Bharath-KumarReddy
Copy link
Author

hi ,
any changes are still needed , in order to merge this PR : )

@nisrulz
Copy link
Owner

nisrulz commented Oct 19, 2023

@Bharath-KumarReddy yes. Please take a look at my last comment. I showcase changes needed in the PR.

  1. The directory structure is not correct in your PR. I have changed that in the commit I mentioned above.
  2. You need to cleanup your code a little bit.
  3. you should not add google-services.json file as it has sensitive info about your Firebase instance and can be misused. Put a placeholder in place. Add instructions in readme for someone to set it up and replace placeholder json with the one the user has.
  4. you should also bundle the iOS app, which is missing. You have macos, web and android.
  5. Add a link in readme index to your app
  6. Mention how to login into your app in readme. It can be hardcoded so it works everytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants