add context-aware method to enable timeout + cancel for connections #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@practice-golang, I couldn't push to your branch, so I've pulled your changes into a branch here. Some minor modifications have been made, but I'd like you to verify (if possible) that the sending still works as expected.
Each context should be passed in per call to
SendWithContext
so that a new context is used per dial, rather than using a global context at the package level. This isn't a super obvious pattern, and I'm sure your solution would have been ok in most cases! This is just a safer way to guarantee that no goroutines share the same context and end up colliding cancellations or timeouts.If you can, please test in the sending environment you have been working in and let me know if there are any issues. Thanks for your help!