Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to import FHMM_Exact using experimentation API #955

Open
Ninad-Golatkar opened this issue Jun 18, 2022 · 5 comments
Open

Unable to import FHMM_Exact using experimentation API #955

Ninad-Golatkar opened this issue Jun 18, 2022 · 5 comments

Comments

@Ninad-Golatkar
Copy link

Unable to import FHMM_Exact using rapid experimentation API (trying to run the sample code)

Error on the following line:

from nilmtk.disaggregate import FHMM_EXACT

Error that I get:

ImportError Traceback (most recent call last)
~\AppData\Local\Temp\ipykernel_10388\371363998.py in
----> 1 from nilmtk.disaggregate import FHMM_EXACT

ImportError: cannot import name 'FHMM_EXACT' from 'nilmtk.disaggregate'

@TomasCostaK
Copy link

The correct import is:
from nilmtk.disaggregate import FHMMExact

@Ninad-Golatkar
Copy link
Author

Thank you so much!
It worked.
How do I get these updates
And how can we get the tutorial sheet updated so new comers can directly use it!

@TomasCostaK
Copy link

Thank you so much! It worked. How do I get these updates And how can we get the tutorial sheet updated so new comers can directly use it!

Well we can create a pull request to change that, but I think that the project hasnt been updated in a while and even the docs point to an old usage of the Exact module.

@Ninad-Golatkar
Copy link
Author

I am new to Github, I will try to learn and would like to keep it updated so that people trying in the future would not be stuck.
Can you help me?

@TomasCostaK
Copy link

I am new to Github, I will try to learn and would like to keep it updated so that people trying in the future would not be stuck. Can you help me?

Sure, all you need to do is fork the repository, make the changes to the rapid experimentation API as you've already detected the typo and then pull request to this project
More info here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants