Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Update circle-ci trigger-hosting #4402

Merged
merged 16 commits into from
Apr 26, 2024
Merged

[MAINT] Update circle-ci trigger-hosting #4402

merged 16 commits into from
Apr 26, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Apr 25, 2024

Changes:

  • triggering the circle-CI workflow is done directly by the github workflow that builds the doc
  • this allows getting rid of a whole github workflow and associated bash script
  • simplify the circle ci workflow as it now needs fewer variables

Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau Remi-Gau changed the title [MAINT] Update cirlce-ci trigger-hosting [MAINT] Update circle-ci trigger-hosting Apr 25, 2024
@@ -59,7 +58,6 @@ jobs:
# To test this workflow on a fork, uncomment the following line.
if: github.repository == 'nilearn/nilearn'
runs-on: ubuntu-latest
timeout-minutes: 360
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the time out is by default 360 minutes anyway

@Remi-Gau Remi-Gau marked this pull request as ready for review April 25, 2024 21:51
@Remi-Gau
Copy link
Collaborator Author

Tests failures are unrelated. See #4404

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall !

.github/workflows/build-docs.yml Outdated Show resolved Hide resolved
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
@Remi-Gau
Copy link
Collaborator Author

will merge so we can know if the artifacts redirects works

@Remi-Gau Remi-Gau merged commit 76b482b into main Apr 26, 2024
28 of 33 checks passed
@Remi-Gau Remi-Gau deleted the Remi-Gau-patch-1 branch April 26, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc not hosted or deployed by circle CI
2 participants