New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add POSIX-TZ support #31
base: master
Are you sure you want to change the base?
Conversation
Hmm...
For reference, 1st July should always be in PDT according to the rule:
|
Thanks a lot! I started working on this about a year ago, but for various reasons haven't finished. 😅 Do you mind if I cherry-pick from your code and merge it with whatever I have? Also, I'm very busy this week, so I'll try to get to this sometime next week! |
Awesome! I wasn't sure how to deal with I just pushed test tweaks I was working on but I'll hold off with any more changes for now to give you time to glue things together. |
... except I think it would be best not to depend on |
This is a big change. Submitting for review as a work in progress. Parsing seems to work. Most functions seem to be updated to use rules when time is past last explicitly stored transition. Implementation (except parsing) is mostly translated from musl libc, which is licensed under MIT so I hope that is fine.
As an example:
Before:
After:
TODO
localToPosix
(andlocalTimeToUTCFull
if needed)