userbrowse.py: handle usernames with invalid path chars in share lists #2892
Conversation
mathiascode
commented
Feb 21, 2024
mathiascode
commented
- Add .json file extension to lists saved to disk
- Add metadata section containing the original username, in case it contained characters that were removed from the filename
- Add .json file extension to lists saved to disk - Add metadata section containing the original username, in case it contained characters that were removed from the filename
mathiascode
force-pushed
the
share-list-usernames
branch
from
76d1cae
to
86e1a61
Compare
| @@ -186,6 +186,9 @@ def iter_matching_folders(self, requested_folder_path, browsed_user, recurse=Fal | |||
| def load_shares_list_from_disk(self, file_path): | |||
|
|
|||
| file_path_encoded = encode_path(file_path) | |||
| suffix = None | |||
| metadata_index = None | |||
| username = None | |||
|
|
|||
| try: | |||
| try: | |||
There was a problem hiding this comment.
This try try except except structure seems clumsy, and this method is becoming too long.
Consider creating small helper function(s) such as:
_open_shares_file()_read_shares_file()_get_metadata_username()
|
This bugs seems low priority, I'd suggest waiting to merge this until 3.3.2.dev1. |
|
Can the new metadata field be used to contain other data in future, for example, favorite folders, file and folder counts? Having such extra metadata would be faster than using iteration for counting items, in order for a feature or plugin to quickly check if the shares list needs updating to get newly added items. Not saying to add anything extra now, just saying the metadata field is a really good idea. Does it need testing to see what happens if the list is loaded by an older version? |
