core_commands: ctcp command with request/reply pairs #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slook
force-pushed
the
core-commands-ctcp-queries
branch
3 times, most recently
from
64a7a9a
to
b5853a1
Compare
slook
force-pushed
the
core-commands-ctcp-queries
branch
from
bf5b641
to
cdbff08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/ctcpversioncommand/ctcpcommand withclientinfo,errmsgandversion"keywords" (clientinfo is the equivalent of help)This experimental PR demonstrates the intention for these 3 keyword commands to be handled somewhere within the core_commands plugin, and then allow other plugins to easily implement optional CTCP-like request/reply pairs if desired.
Another simplified PR will follow without the extra request/reply pairs.