Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Puppet challenge (stateMutability issue) #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

typicalHuman
Copy link

Fix Uniswapv1 ABIs for newer versions of Foundry (stateMutability bug)

Type of change

  • Bug fix

@typicalHuman typicalHuman changed the title Fix Puppet challeng (stateMutability issue) Fix Puppet challenge (stateMutability issue) Feb 6, 2024
@brightredchilli
Copy link

brightredchilli commented Feb 23, 2024

Thanks for posting this. I wasn't able to get this challenge to work unless similar changes are also made to the V1UniswapFactory. Did you forget to commit those, or is there some other diff in our set ups?

These are my changes:

brightredchilli@e2ec3e5#diff-5ad4d30aa03a6ff4eadafa155f9ea2c3bbbd1e1cbd4362bbaa619a498c886f20

Edit: sorry, I missed the change to second file.

@typicalHuman
Copy link
Author

typicalHuman commented Feb 24, 2024

Thanks for posting this. I wasn't able to get this challenge to work unless similar changes are also made to the V1UniswapFactory. Did you forget to commit those, or is there some other diff in our set ups?

These are my changes:

brightredchilli@e2ec3e5#diff-5ad4d30aa03a6ff4eadafa155f9ea2c3bbbd1e1cbd4362bbaa619a498c886f20

Hi, could you please explain what you mean? I think it should work with these changes, at least it's working on my side - so I decided to create a PR, maybe this would be helpful for the others struggling with this problem.

Feel free to check my solutions if you are confused:
https://github.com/typicalHuman/damn-vulnerable-defi-foundry-solutions

@brightredchilli
Copy link

My bad - your pr has the diff to both the files. I missed the changes to UniswapV1Factory.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants