Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet v3 #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

danielles0xG
Copy link

@danielles0xG danielles0xG commented Apr 10, 2023

Describe your changes

Proposing add of puppet-v3 challenge template.

Fixes # (issue)
I compiled only the needed functions on interfaces and libraries needed for the setup.
I decided to add and deploy from build jsons since Tincho's puppet-v3 version is specific =0.7.6, and this was giving compilation issues.
Updated forge-std lib.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nicolasgarcia214
Copy link
Owner

Thanks for contributing I'll check it tomorrow 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants