chore: Fix the play framework dependency on docker-compose.yml #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repository alexproca/play:2.2.3 is not maintained anymore. ifinavet/playframework:2.2.3 does the same thing and seems pretty well organized. This patch fixes the docker-compose dev environment.
eyal-lezmy
force-pushed
the
fix/docker-play-dep
branch
from
9757906
to
a0923e8
Compare
|
This pull request fixes #85 |
|
Since there is not a official build for play framework I created mine then forget is used here and deleted it. The replacement with ifinavet/playframework will fix the problem for now but won't prevent the same think will happen in the future. The fix would be to create a play.dockerfile and tell docker-compose to build play image based on some official image like openjdk:7 docker-compose.yml play:
build:
context: .
dockerfile: play.dockerfile
volumes:
- .:/app:rw
ports:
- "9000:9000"play.dockerfile FROM openjdk:7
ENV PLAY_VERSION 2.2.6
RUN wget -q https://downloads.typesafe.com/play/${PLAY_VERSION}/play-${PLAY_VERSION}.zip \
&& unzip -q play-${PLAY_VERSION}.zip \
&& rm play-${PLAY_VERSION}.zip \
&& ln -s /play-${PLAY_VERSION}/play /usr/local/bin/ |
|
@alexproca thanks for the feedback. I'll try to update the PR asap. |
|
Ok, @aheritier will do a review and merge it, thanks :-) |
nicmarti
added a commit
that referenced
this pull request
Dec 11, 2017
This PR replaces #84 and add the change proposed by @alexproca cc @eyal-lezmy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository alexproca/play:2.2.3 is not maintained anymore. And there is no alternative on Alex's profile.
ifinavet/playframework:2.2.3 does the same thing and seems pretty well organised.