Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort apps by package name #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sort apps by package name #15

wants to merge 2 commits into from

Conversation

TarasMazepa
Copy link

So users will get at least some predictability when they see list of icons :)

So users will get at least some predictability when they see list of icons :)
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Copy link
Owner

@nickbutcher nickbutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, one small comment.

@TarasMazepa
Copy link
Author

sortBy returns Unit. To do this fluently apply should be used :)

making changes due to feedback after review
@TarasMazepa
Copy link
Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@TarasMazepa
Copy link
Author

Hey, please merge!

@TarasMazepa
Copy link
Author

@nickbutcher can you please merge this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants