-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort apps by package name #15
base: master
Are you sure you want to change the base?
Conversation
So users will get at least some predictability when they see list of icons :)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
app/src/main/java/uk/co/nickbutcher/adaptiveiconplayground/MainActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, one small comment.
sortBy returns Unit. To do this fluently apply should be used :) |
making changes due to feedback after review
I signed it! |
CLAs look good, thanks! |
Hey, please merge! |
@nickbutcher can you please merge this change? |
So users will get at least some predictability when they see list of icons :)