New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fill types #834

Open

k10wl wants to merge 1 commit into nhn:master from k10wl:bugfix/shape-fill-types

k10wl commented Dec 26, 2022 •

edited

Fix for mismatch types for fill types

Please check if the PR fulfills these requirements

It's submitted to right branch according to our branching model
It's right issue type on title
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
It does not introduce a breaking change or has description for the breaking change

Description

Documentations states that objects can have fill option as either string or ShapeFillOption, but it was not typed.
rel: https://nhn.github.io/tui.image-editor/latest/ShapeFillOption

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨


          Fix for fill types

ac123fb

rel:https://nhn.github.io/tui.image-editor/latest/ShapeFillOption

stale bot commented Jun 18, 2023

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

stale bot added the inactive label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment