WIP Fix validating similar but not equal column types #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
reviewed
Jan 18, 2022
| @@ -1035,7 +1036,10 @@ public IEnumerable<string> ValidateColumns(Dialect.Dialect dialect, IMapping map | |||
| } | |||
|
|
|||
| //TODO: Add new method to ColumnMetadata :getTypeCode | |||
| bool typesMatch = column.GetSqlType(dialect, mapping).StartsWith(columnInfo.TypeName, StringComparison.OrdinalIgnoreCase); | |||
There was a problem hiding this comment.
Why not simply check that next char is not a letter (char.IsLetter)?
There was a problem hiding this comment.
I was/am thinking about that. Even have code about to push. But it is not that simple.
is not a letter
Oracle is pouncing with (n)varchar/(n)varchar2...
There was a problem hiding this comment.
Still see no reasons to use regex - check additionally for not a digit (char.IsDigit). Alphanumeric character check should suffice
There was a problem hiding this comment.
Yes, I hate the regex myself. But that is not that easy really. For example, Db2's CHAR(16) FOR BIT DATA would match to CHAR(16) even in my implementation with regex.
hazzik
force-pushed
the
gh1895
branch
2 times, most recently
from
d1ff749
to
cf8f810
Compare
hazzik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixes similar column types checks for precision and scale is not implemented, because:
From @fredericDelaporte:
Fixes #1895