Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite existing conformance files #1951

Merged
merged 2 commits into from May 14, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented May 9, 2024

Proposed changes

We don't want to throw an error when uploading the conformance profile, with this flag it will just overwrite existing files.

Closes #1747

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner May 9, 2024 20:58
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 9, 2024
@lucacome lucacome enabled auto-merge (squash) May 14, 2024 15:56
@lucacome lucacome merged commit 0098b07 into nginxinc:main May 14, 2024
34 checks passed
@lucacome lucacome deleted the chore/upload-conformance branch May 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Conformance profile should not upload if already exists
3 participants