Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: make the .pc file relocatable #1824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lazka
Copy link

@lazka lazka commented Oct 31, 2022

Instead of writing absolute file paths for exec_prefix, libdir and
includedir make them all relative to prefix. This makes the .pc
file match the autotools generated one and allows changing all paths
via prefix.

Before:

prefix=C:/test
exec_prefix=C:/test
libdir=C:/test/lib
includedir=C:/test/include

After:

prefix=C:/test
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

While CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR are by default
relative paths, cmake allows users to override them with absolute ones,
so in case they are absolute write them as is into the .pc file and
not relative to the prefix.

@lazka lazka marked this pull request as draft November 1, 2022 13:51
@lazka
Copy link
Author

lazka commented Nov 1, 2022

(someone mentioned CMAKE_INSTALL_LIBDIR can be absolute. I'll update this PR to handle that case)

Instead of writing absolute file paths for exec_prefix, libdir and
includedir make them all relative to prefix. This makes the .pc
file match the autotools generated one and allows changing all paths
via prefix.

Before:

prefix=C:/test
exec_prefix=C:/test
libdir=C:/test/lib
includedir=C:/test/include

After:

prefix=C:/test
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

While CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR are by default
relative paths, cmake allows users to override them with absolute ones,
so in case they are absolute write them as is into the .pc file and
not relative to the prefix.
@lazka
Copy link
Author

lazka commented Jul 24, 2023

(someone mentioned CMAKE_INSTALL_LIBDIR can be absolute. I'll update this PR to handle that case)

done now, better late then never :)

@lazka lazka marked this pull request as ready for review July 24, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant