Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the div of the placeholder if there is no content. #2344

Conversation

high54
Copy link

@high54 high54 commented Feb 7, 2024

To facilitate layout management (CSS flex, etc.), if the placeholder variable is undefined, then it is unnecessary to display the div.

Copy link

@MaximeSauliere MaximeSauliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me.

@coveralls
Copy link

coveralls commented Feb 10, 2024

Coverage Status

coverage: 92.505% (-1.4%) from 93.951%
when pulling 6516d20 on high54:feature/removing-placeholder-div-if-no-content
into c02a6c4 on ng-select:master.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆

@github-actions github-actions bot added the stale label Apr 11, 2024
@github-actions github-actions bot closed this Apr 19, 2024
@pavankjadda pavankjadda reopened this Apr 20, 2024
@github-actions github-actions bot removed the stale label Apr 21, 2024
@pavankjadda
Copy link
Collaborator

@high54 I don't see the issue here. And this does not fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants