feat: add boolean and number transformers #2333
Open
+30
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dafnik what does this achieve? |
|
Ohh, sorry for not explaining earlier. It allows boolean and number inputs to passed like a string. <ng-select-example multiple="true" />
// Instead of
<ng-select-example [multiple]="true" />or even just <ng-select-example multiple />to set a boolean to true. The docs are really none-existent on this. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆 |
pavankjadda
requested changes
May 23, 2024
|
@Dafnik I like the PR. Fix conflicts and push new update |
pavankjadda
added
new feature
and removed
stale
needs info
adding to ng-dropdown-panel, ng-option and ng-select
Dafnik
force-pushed
the
feature/add-input-transformers
branch
from
87d4ac7
to
0b4ac58
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding to ng-dropdown-panel, ng-option and ng-select