Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update public-api.ts #2160

Merged
merged 8 commits into from May 23, 2024
Merged

fix: update public-api.ts #2160

merged 8 commits into from May 23, 2024

Conversation

xCMSjQuery
Copy link
Contributor

Required to support lazy loading in a feature module's component.

@component({
providers: [{ provide: SELECTION_MODEL_FACTORY, useValue: DefaultSelectionModelFactory}]
})

xCMSjQuery and others added 2 commits November 11, 2022 14:41
Required to support lazy loading in a feature module's component.

@component({
  providers: [{ provide: SELECTION_MODEL_FACTORY, useValue: DefaultSelectionModelFactory}]
})
@coveralls
Copy link

coveralls commented Nov 14, 2022

Coverage Status

Coverage: 93.468%. Remained the same when pulling 8463bfb on xCMSjQuery:master into ef9025b on ng-select:master.

@pavankjadda
Copy link
Collaborator

@xCMSjQuery how does this related to Lazy loading?

@pavankjadda pavankjadda self-requested a review November 22, 2022 05:58
@pavankjadda pavankjadda self-assigned this Nov 22, 2022
@pavankjadda pavankjadda added the needs reproduction needs reproducible example label Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆

@github-actions github-actions bot added the stale label Mar 6, 2023
@github-actions github-actions bot closed this Mar 14, 2023
@pavankjadda pavankjadda reopened this Apr 21, 2024
@github-actions github-actions bot removed the stale label Apr 22, 2024
Copy link
Collaborator

@pavankjadda pavankjadda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavankjadda pavankjadda changed the title Update public-api.ts fix: update public-api.ts May 23, 2024
@pavankjadda pavankjadda merged commit 74b62ff into ng-select:master May 23, 2024
6 checks passed
Copy link

🎉 This PR is included in version 13.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction needs reproducible example released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants