Checking EXPORT Block Parameters at Client End #26
Conversation
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
| echo "FAILURE Since Write Permissions Were Not Blocked To The Client" | ||
| exit ret | ||
| else | ||
| echo "SUCCESS ON WRITE PERMISSIONS FAILURE" |
There was a problem hiding this comment.
This should probably not include the word "FAILURE"
There was a problem hiding this comment.
@dang
What I meant here is ... The expected output is that the write permissions should fail ....
Should I give a better wording like ... "SUCCESS ON WRITE PERMS DECLINED" ?
There was a problem hiding this comment.
That would be fine, yes. It's just that people (and CI frameworks) frequently look for FAIL and FAILURE in output, so see if a test failed. In this case, it is succeeding, so it shouldn't use the word FAIL. Anything else (like DECLINED) is fine.
| echo "FAILURE Since v4.0 Permissions Were Not Given To The Client" | ||
| exit ret | ||
| else | ||
| echo "SUCCESS ON v4.0 MOUNT FAILURE" |
There was a problem hiding this comment.
This should probably not use the word FAILURE
| echo "FAILURE Since v4.1 Permissions Were Not Given To The Client" | ||
| exit ret | ||
| else | ||
| echo "SUCCESS ON v4.1 MOUNT FAILURE" |
There was a problem hiding this comment.
This should probably not use the word FAILURE
| echo "FAILURE Since v3 Permissions Were Not Given To The Client" | ||
| exit ret | ||
| else | ||
| echo "SUCCESS ON v3 MOUNT FAILURE" |
There was a problem hiding this comment.
This should probably not use the word FAILURE
| echo "FAILURE Since v4 Mounts Are To Use Pseudo Paths" | ||
| exit ret | ||
| else | ||
| echo "SUCCESS ON v4.0 MOUNT FAILURE DUE TO NOT USING PSEUDO PATH" |
There was a problem hiding this comment.
This should probably not use the word FAILURE
| systemctl stop firewalld || service iptables stop | ||
|
|
||
| # TODO: SELinux prevents creating special files on Gluster bricks (bz#1331561) | ||
| setenforce 0 |
| #Parsing export id from volume export conf file | ||
| export_id=$(grep 'Export_Id' ${conf_file} | sed 's/^[[:space:]]*Export_Id.*=[[:space:]]*\([0-9]*\).*/\1/') | ||
|
|
||
| sed -i '12s/.*/\t\tAccess_type = RO;/' ${conf_file} |
There was a problem hiding this comment.
This should probably do a search and replace instead of replacing a specific line.
There was a problem hiding this comment.
Ok ... :) ..
Will Do it for the similar errors below tooo
| #Parsing export id from volume export conf file | ||
| export_id=$(grep 'Export_Id' ${conf_file} | sed 's/^[[:space:]]*Export_Id.*=[[:space:]]*\([0-9]*\).*/\1/') | ||
|
|
||
| sed -i '12s/.*/\t\tAccess_type = RO;/' ${conf_file} |
| #Parsing export id from volume export conf file | ||
| export_id=$(grep 'Export_Id' ${conf_file} | sed 's/^[[:space:]]*Export_Id.*=[[:space:]]*\([0-9]*\).*/\1/') | ||
|
|
||
| sed -i '15s/.*/\tPseudo="\/ppath";/' ${conf_file} |
| #Parsing export id from volume export conf file | ||
| export_id=$(grep 'Export_Id' ${conf_file} | sed 's/^[[:space:]]*Export_Id.*=[[:space:]]*\([0-9]*\).*/\1/') | ||
|
|
||
| sed -i '14s/.*/\t\tSquash = "root_squash";/' ${conf_file} |
rakshithakamath94
force-pushed
the
centos-ci
branch
28 times, most recently
from
8d13406
to
8ed5d89
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
3 times, most recently
from
0171c68
to
d4f7c74
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
8 times, most recently
from
3a08930
to
9799328
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
2 times, most recently
from
801b37d
to
c770b94
Compare
rakshithakamath94
force-pushed
the
centos-ci
branch
17 times, most recently
from
e9b2ca4
to
a09a2e5
Compare
Signed-off-by: Mohammed Azhar Padariyakam mpadariy@redhat.com