Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-Number Enhancements - Ascat penality #1510

Open
seedgeorge opened this issue May 7, 2024 · 1 comment
Open

Copy-Number Enhancements - Ascat penality #1510

seedgeorge opened this issue May 7, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@seedgeorge
Copy link

seedgeorge commented May 7, 2024

Description of feature

Hi there.
I think Sarek is in a good place with the current ASCAT implementation, but I'd like to point towards two things that I think would be helpful for the community.

  • The function ascat.aspcf() (found in the ascat module) accepts a parameter penalty which controls the sensitivity of the tool to potential segment breakpoints. The default is 70 which is usually fine, but for individuals using panel/wes data being able to change this value might be helpful - any chance of exposing this as a param?

Kind regards,
George

EDIT by @maxulysse - created #1512

@seedgeorge seedgeorge added the enhancement New feature or request label May 7, 2024
@maxulysse maxulysse changed the title Copy-Number Enhancements Copy-Number Enhancements - ascat_penality May 7, 2024
@maxulysse
Copy link
Member

The function ascat.aspcf() (found in the ascat module) accepts a parameter penalty which controls the sensitivity of the tool to potential segment breakpoints. The default is 70 which is usually fine, but for individuals using panel/wes data being able to change this value might be helpful - any chance of exposing this as a param?

This seems easy enough, I'm fairly sure we can add that for 3.5.0

I split your initial issue in 2 different feature requests

@maxulysse maxulysse changed the title Copy-Number Enhancements - ascat_penality Copy-Number Enhancements - Ascat penality May 7, 2024
@maxulysse maxulysse added this to the 3.5 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants