Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify MS2PIP model directory #322

Merged
merged 4 commits into from
May 28, 2024

Conversation

jonasscheid
Copy link
Collaborator

@jonasscheid jonasscheid commented May 12, 2024

Adding option --ms2pip_model_dir as requested in #317 to specify a local directory holding the MS2PIP models that would otherwise be automatically downloaded from https://genesis.ugent.be/uvpublicdata/ms2pip/

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mhcquant branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jonasscheid jonasscheid changed the base branch from master to dev May 12, 2024 21:05
@nf-core nf-core deleted a comment from github-actions bot May 12, 2024
Copy link

github-actions bot commented May 12, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit 3dd15c0

+| ✅ 233 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-13 12:05:50

@nf-core nf-core deleted a comment from github-actions bot May 12, 2024
Copy link
Collaborator

@marissaDubbelaar marissaDubbelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasscheid jonasscheid merged commit 2b22ec7 into nf-core:dev May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants