Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev version: On parameters website list parameter gene_sets_files in section GSEA #243

Open
aghr opened this issue Feb 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@aghr
Copy link

aghr commented Feb 23, 2024

Description of feature

I noticed that in the dev version the GSEA parameter --gsea_gene_sets disappeared and now one should use --gene_sets_files. I'd have two suggestions:

  1. For backward compatibility keep the parameter gsea_gene_sets next to gene_sets_files so users won't need to change there parameter files when working with different versions of the pipeline.

  2. Move the description of the parameter gene_sets_files from on the webpage from section 'Options related to gene set analysis' to section 'GSEA' so users find it more easyly when searching for info on GSEA configuration.

@aghr aghr added the enhancement New feature or request label Feb 23, 2024
@WackerO
Copy link
Collaborator

WackerO commented Mar 18, 2024

Hey @aghr,
so the issue is that this param is now used as the central parameter for accepting gene set files for both GSEA and gprofiler (and possibly other tools in the future). That's why it shouldn't be moved to GSEA.
The backward compatibility is interesting, is this something that's done in nf-core pipelines? I'm however also a bit hesitant to do this as it will clutter the pipeline even more with parameters. I think when switching to a new pipeline version, users should have a look at the updated params and check if something changed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants