Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shinyngs modules to address density plots issue #221

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Update shinyngs modules to address density plots issue #221

merged 3 commits into from
Jan 10, 2024

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Jan 8, 2024 •
edited

Pulling in pinin4fjords/shinyngs#58 in attempted resolution of #196.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited

nf-core lint overall result: Passed ✅

Posted for pipeline commit 8c8bb07

+| ✅ 164 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-10 15:03:06

@pinin4fjords pinin4fjords mentioned this pull request Jan 8, 2024
Open
@pinin4fjords
Copy link
Member Author

Thanks @maxulysse !

@pinin4fjords pinin4fjords linked an issue Jan 10, 2024 that may be closed by this pull request
"exclude" samples aren't respected in SHINYNGS_STATICEXPLORATORY - Error in cor(matrices[[g]]) : supply both 'x' and 'y' or a matrix-like 'x' #196
Open
@pinin4fjords pinin4fjords merged commit b21659c into dev Jan 10, 2024
14 checks passed
@pinin4fjords pinin4fjords deleted the bump_shinyngs_for_density branch January 10, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@WackerO WackerO Awaiting requested review from WackerO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pinin4fjords @maxulysse