Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add types to exports objects #2640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gsong
Copy link

@gsong gsong commented May 2, 2024

Changes proposed in this PR:

This allows packages that are declared as type: module and uses tsc to transpile to work properly. Otherwise the types cannot be found.

@nexxtway/react-rainbow

@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
All committers have signed the CLA.

@gsong gsong changed the title build: add types to exports objects chore: add types to exports objects May 2, 2024
This allows packages that are declared as `type: module` and uses
tsc to transpile to work properly. Otherwise the types cannot be found.
@gsong gsong force-pushed the build/tsc-esm-compatible-exports branch from 46ee77a to c4b0cb4 Compare May 2, 2024 04:50
Copy link

codeclimate bot commented May 2, 2024

Code Climate has analyzed commit c4b0cb4 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants