Avoids copying public parameters #78
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another reminder not to stack changes into a single branch. This one is heavily outdated and it makes reviews difficult, not to mention merging. |
dorebell
force-pushed
the
dorebell-spartan-memory
branch
from
daf625a
to
e5cc4b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to avoid making copies of portions of the SRS when calling the Zeromorph
trim()function, by replacing vectors of group elements with CoW references (a similar technique is used in theark-poly-commitcrate).The compression tests are working, but the peak memory usage is still around 57GB. I'm not sure what exactly is going on here - running further comprehensive benchmarks should help.