Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: dataset table is broken on Windows #903

Open
ivan-aksamentov opened this issue Jun 27, 2022 · 0 comments
Open

CLI: dataset table is broken on Windows #903

ivan-aksamentov opened this issue Jun 27, 2022 · 0 comments
Labels
hard problem help wanted Extra attention is needed t:bug Type: bug, error, something isn't working

Comments

@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Jun 27, 2022 •
edited

On Windows 7, in both Cmd and PowerShell, when issuing nextclade.exe dataset list command, it prints a table with columns not having proper spacing and with cryptic characters inside the cells. It's completely unreadable.

At the time of writing, the table is formatted using comfy-table crate, which claims Windows support.

Needs checking on more recent Windows versions.

Even if it works on more recent versions on Windows, and although Windows 7 is no longer supported, it may still be used in many places. Would be nice to allow these users to have full experience.
@ivan-aksamentov ivan-aksamentov added t:bug Type: bug, error, something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jun 27, 2022
ivan-aksamentov added a commit that referenced this issue Jun 27, 2022
@ivan-aksamentov
Here I attempt to fix #903
838b675 
No luck so far. Disabling `Utf8` profile and other niceties leads to ASCII-formatted table, which is equally unreadable, just with ASCII borders, instead of nice UTF-8 lines.

So the lines might not be the problem here.

Needs more work.
ivan-aksamentov added a commit that referenced this issue Jun 27, 2022
@ivan-aksamentov
fix(cli): attempt to fix dataset table on windows
dc622cd 
Here I attempt to fix #903

No luck so far. Disabling `Utf8` profile and other niceties leads to ASCII-formatted table, which is equally unreadable, just with ASCII borders, instead of nice UTF-8 lines.

So the lines might not be the problem here.

Needs more work.
@ivan-aksamentov ivan-aksamentov mentioned this issue Jun 27, 2022
Closed
@ivan-aksamentov ivan-aksamentov added hard problem and removed good first issue Good for newcomers labels Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hard problem help wanted Extra attention is needed t:bug Type: bug, error, something isn't working
Projects
No open projects
Nextstrain planning (archived)
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CLI dataset table on Windows nextstrain/nextclade
1 participant
@ivan-aksamentov