Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title-wrap #2640

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Title-wrap #2640

wants to merge 6 commits into from

Conversation

mchugh19
Copy link

@mchugh19 mchugh19 commented Apr 13, 2024

Summary

Changes artitle title from clipped elipis to wrap.
image

(based on top of Vue improvements 2 branch @powerpaul17 )

Checklist

powerpaul17 and others added 6 commits March 21, 2024 20:22
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
@SMillerDev
Copy link
Contributor

Can you make a PR to merge this into the other PR? Otherwise we have two for the same code.

@powerpaul17
Copy link
Contributor

In my personal opinion, this does not look good and the nowrap/ellipsis was done on purpose. I don't want my list items to grow vertically just because my screen is to narrow. I am also not aware of any other application where this is the case.

@SMillerDev
Copy link
Contributor

SMillerDev commented Apr 15, 2024

Is this for the list or the detail?

@powerpaul17
Copy link
Contributor

powerpaul17 commented Apr 15, 2024

Is this for the list or the detail?

Good question, I thought it referred to the list

@mchugh19
Copy link
Author

Sorry for the delay in replying. Github seems to have stopped notifying me about replies.

Anyway, this was a css change for the list content on the left. I've found in using the news application, that it's easier to use the app on my phone as the strict cutoff of titles in the web app makes for a frustrating experience. My use case is not using the article view much, but scanning content via the list and if it's something I'm interested in, clicking (until keyboard shortcuts are enabled at least) into the article content at the orginal source. Thus, I'm more interested in the list view, and would be content to hide he article view.

In coming from google reader and feedly, the list is the main content, and the full article view pops out below it.
image
You can get to the site for the article quickly this way, and if you expand the content, it is displayed in line with the main list view
image
The list view as the main content makes it easier to scan through a large folder of feed updates without having to click into each one, while the cut off of titles makes this more frustrating.

I'm not intending to demand big changes, but if this makes sense perhaps there could be a settings page to toggle between display layouts to emulate other rss readers? I'm not super comfortable with the codebase or vue enough to have high confidence of pulling this off myself, but I'd be happy to help as time allows.

@mchugh19
Copy link
Author

Here's what the news phone app displays vs what you see via the news web interface.

App
Screenshot_20240419-083932

Web
Screenshot_20240419-084132~2

These were taken on my phone, but on a larger display the same missing information from lack of titles persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants