More appropriate circle section wording

[Jerome-Herbinet]

"user" groups instead of "contact" groups because here are only listed user groups and not contact groups (if I'm not mistaking).

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (18e7d7f) 2.10% compared to head (67f45d1) 2.10%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #3441   +/-   ##
=====================================
  Coverage   2.10%   2.10%           
=====================================
  Files         88      88           
  Lines       5283    5283           
  Branches    1464    1464           
=====================================
  Hits         111     111           
  Misses      5057    5057           
  Partials     115     115           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jancborchardt]

Indeed it does not take "Contact groups" here but just the regular groups from the accounts. It should be simply called "Groups", as we call it like that elsewhere too.

It also needs to be adjusted in the "Add members" modal for the subheading, if you'd like to do that as well @Jerome-Herbinet :)

[Jerome-Herbinet]

Indeed it does not take "Contact groups" here but just the regular groups from the accounts. It should be simply called "Groups", as we call it like that elsewhere too.

It also needs to be adjusted in the "Add members" modal for the subheading, if you'd like to do that as well @Jerome-Herbinet :)

@jancborchardt I understand what you're saying and the arguments behind it, and I'll let you have the last word on what needs to be done. :-)

Nevertheless, I'm giving you my impressions as a user, before making any last changes.

If, in the same interface, you have "Contact groups" in the left-hand column (linked to the contacts in the address books), and "Groups" in the middle column to make up the Circles, there's bound to be confusion, because if in one case you specify what type of group it is, but not in the other, all doubts are allowed and users will legitimately think that these are also contact groups. In my opinion, the initial naming rules should be departed from here, because in the same interface there are two types of group: contact groups and user groups. Elsewhere in Nextcloud, when there can be no confusion, we can make do with "Groups" without any problem, but not in this specific case, which I think is an exception.

In French, we have an expression to describe that : "This exception is the one that proves the rule." :-D

What do you think ?

[jancborchardt]

You're right @Jerome-Herbinet. Actually I'm a bit confused since I thought Circles allows you to add both "account groups" and "contact groups" to a circle. The omission of "contact groups" is a bit strange since contacts individually can be added.

@ArtificialOwl any specific reason here?

[ArtificialOwl]

You're right @Jerome-Herbinet. Actually I'm a bit confused since I thought Circles allows you to add both "account groups" and "contact groups" to a circle. The omission of "contact groups" is a bit strange since contacts individually can be added.

@ArtificialOwl any specific reason here?

It has never been officially requested :-)

[Jerome-Herbinet]

Hello @jancborchardt @ArtificialOwl,
What's the roadmap about this PR and/or the circle enhancement to take in account contact groups ?
Cheers,
Jerome

[Jerome-Herbinet]

Hello @jancborchardt @ArtificialOwl, What's the roadmap about this PR and/or the circle enhancement to take in account contact groups ? Cheers, Jerome

@jancborchardt @ArtificialOwl , any news ?