Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Powered By Vercel logo URL #10914

Merged
merged 2 commits into from
May 15, 2024

Conversation

k-taro56
Copy link
Contributor

@k-taro56 k-taro56 commented May 14, 2024

☕️ Reasoning

Fix broken Powered By Vercel logo link

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

No Issue

📌 Resources

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 5:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 5:45pm

Copy link

vercel bot commented May 14, 2024

@k-taro56 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.39%. Comparing base (159c38d) to head (7ae29b9).

❗ Current head 7ae29b9 differs from pull request most recent head 8c62500. Consider uploading reports for the commit 8c62500 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10914   +/-   ##
=======================================
  Coverage   38.39%   38.39%           
=======================================
  Files         176      176           
  Lines       27454    27454           
  Branches     1206     1212    +6     
=======================================
  Hits        10541    10541           
  Misses      16913    16913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91
Copy link
Member

ndom91 commented May 15, 2024

Thanks for pointing this out! However, we'd prefer not to have this on a users domain.

Could you add the image to the /docs/public/img/* dir and update the path to that? 🙏

@k-taro56 k-taro56 changed the title chore(example): update Powered By Vercel logo URL chore: update Powered By Vercel logo URL May 15, 2024
@k-taro56
Copy link
Contributor Author

@ndom91

Is this okay?

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 🙏

@ndom91 ndom91 merged commit 77d89d7 into nextauthjs:main May 15, 2024
9 of 11 checks passed
@k-taro56 k-taro56 deleted the chore/update-logo-url branch May 15, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants