Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add new edge-compatibility overview guide #10906

Merged
merged 8 commits into from
May 15, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented May 14, 2024

☕️ Reasoning

  • WIP
  • One definitive "Edge Compatibility" docs page that explains
    • What edge even means
    • How Auth.js fits into this, i.e. what the problem for us is here
    • What you can do to fix it
  • This should hopefully be a page we can link people off to when they have any level of question about edge-related stuff, no matter the adapter or other library they're trying to integrate with 🙏

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 9:43am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:43am
proxy ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:43am

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.39%. Comparing base (e723f4e) to head (cb71400).

❗ Current head cb71400 differs from pull request most recent head 5b1a591. Consider uploading reports for the commit 5b1a591 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10906   +/-   ##
=======================================
  Coverage   38.39%   38.39%           
=======================================
  Files         176      176           
  Lines       27454    27454           
  Branches     1206     1206           
=======================================
  Hits        10541    10541           
  Misses      16913    16913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 changed the title feat: add new edge-compatibility overview guide page chore(docs): add new edge-compatibility overview guide May 14, 2024
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

docs/pages/guides/edge-compatibility.mdx Outdated Show resolved Hide resolved
docs/pages/guides/edge-compatibility.mdx Outdated Show resolved Hide resolved
docs/pages/guides/edge-compatibility.mdx Outdated Show resolved Hide resolved
docs/pages/guides/edge-compatibility.mdx Outdated Show resolved Hide resolved
docs/pages/guides/edge-compatibility.mdx Outdated Show resolved Hide resolved
docs/pages/guides/edge-compatibility.mdx Outdated Show resolved Hide resolved
@ndom91 ndom91 marked this pull request as ready for review May 15, 2024 09:42
@ndom91 ndom91 requested a review from ubbe-xyz as a code owner May 15, 2024 09:42
@ndom91 ndom91 merged commit e26fcf2 into main May 15, 2024
9 of 10 checks passed
@ndom91 ndom91 deleted the ndom91/new-definitive-edge-docs-page branch May 15, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants