Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): re-enable nextjs-docker tests #10863

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented May 9, 2024

☕️ Reasoning

  • Re-enable the Run E2E tests (Nextjs-Docker) test
    • Have to build one of our apps into the container
    • This requires adding the Credentials provider, but we don't want it in the deployed example, so it has to be filtered out via Env var, for example.
  • The normal Run E2E tests job (running playwright in the GHA container directly against the dev app in the container), seems to be stable and passing every time

Todo

For some reason, the example app in the container is throwing configuration errors when trying to visit /auth/signin directly (for example). Works fine locally (when built into a container).

See example playwright trace.zip, which can be viewed at https://trace.playwright.dev

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 4:19pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 4:19pm
proxy ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 4:19pm

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.51%. Comparing base (5e55331) to head (efb4da4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10863   +/-   ##
=======================================
  Coverage   37.51%   37.51%           
=======================================
  Files         173      173           
  Lines       26983    26983           
  Branches     1176     1176           
=======================================
  Hits        10122    10122           
  Misses      16861    16861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented May 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sveltejs/adapter-auto@3.2.0 environment +1 84.2 kB svelte-admin
npm/@sveltejs/kit@2.5.7 environment, eval Transitive: filesystem +15 1.47 MB svelte-admin
npm/@sveltejs/vite-plugin-svelte@3.1.0 Transitive: environment +8 798 kB svelte-admin
npm/@types/express@4.17.21 None +9 107 kB types
npm/@types/morgan@1.9.9 None 0 13.9 kB types
npm/@types/node@18.19.33 None 0 1.97 MB types
npm/@types/node@20.12.7 None 0 2.03 MB types
npm/@types/react-dom@18.3.0 None 0 37.8 kB types
npm/@types/react@18.3.1 None 0 438 kB types
npm/clsx@2.1.1 None 0 8.55 kB lukeed
npm/express@4.19.2 environment, filesystem, network Transitive: eval, unsafe +59 2.05 MB wesleytodd
npm/morgan@1.10.0 eval Transitive: environment, filesystem, network +8 181 kB dougwilson
npm/next@14.2.3 environment, filesystem, network, shell, unsafe +13 1.2 GB vercel-release-bot
npm/pug@3.0.2 environment, eval, filesystem +43 6.46 MB pug-bot
npm/react-dom@18.3.1 environment +1 4.61 MB react-bot
npm/react@18.3.1 environment 0 318 kB react-bot
npm/svelte-check@3.6.9 Transitive: environment, eval, filesystem, unsafe +31 10.5 MB svelte-language-tools-deploy
npm/svelte@4.2.15 Transitive: unsafe +17 6.31 MB svelte-admin
npm/tsx@4.7.3 Transitive: environment, filesystem, network, shell, unsafe +3 630 kB hirokiosame
npm/typescript@5.3.3 None 0 32 MB typescript-bot
npm/typescript@5.4.5 None 0 32.4 MB typescript-bot
npm/vite@5.2.10 environment, eval, filesystem, network, shell, unsafe +3 6.01 MB vitebot

🚮 Removed packages: npm/@actions/core@1.10.1, npm/@ariakit/react@0.4.5, npm/@auth/prisma-adapter@2.0.0, npm/@auth/unstorage-adapter@2.0.0, npm/@aws-sdk/client-dynamodb@3.499.0, npm/@aws-sdk/lib-dynamodb@3.499.0, npm/@azure/data-tables@13.2.2, npm/utils@0.0.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/svelte-preprocess@5.1.3
  • Install script: postinstall
  • Source: echo "[svelte-preprocess] Don't forget to install the preprocessors packages that will be used: sass, stylus, less, postcss & postcss-load-config, coffeescript, pug, etc..."
Install scripts npm/@sveltejs/kit@2.5.7
  • Install script: postinstall
  • Source: node postinstall.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/svelte-preprocess@5.1.3
  • @SocketSecurity ignore npm/@sveltejs/kit@2.5.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant