Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update migrating-to-v5.mdx client component example copy #10747

Merged
merged 21 commits into from
May 19, 2024

Conversation

chriseling
Copy link
Contributor

Updating docs to clarify based on speedbumps I encountered during the migration process. Please check for correctness.

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Updating docs to clarify based on speedbumps I encountered during the migration process.  Please check for correctness.
Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) May 19, 2024 11:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 19, 2024 11:05am

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in general some nice additions, lets clean it up a bit and we can merge it 👍

@ndom91 ndom91 changed the title Update migrating-to-v5.mdx chore(docs): update migrating-to-v5.mdx copy Apr 28, 2024
Updating docs to clarify based on speedbumps I encountered during the migration process.
Copy link

vercel bot commented Apr 28, 2024

@chriseling is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@chriseling
Copy link
Contributor Author

Fixed lint and formatting

Copy link

github-actions bot commented May 6, 2024

Broken Link Checker

1 broken links found. Links organised below by source page, or page where they were found.

1) /getting-started/session-management/protecting

Target Link Link Text
/getting-started/session-management/protecting&framework=express "the examples above"

@ndom91 ndom91 changed the title chore(docs): update migrating-to-v5.mdx copy chore(docs): update migrating-to-v5.mdx client component example copy May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.74%. Comparing base (118b1b2) to head (e7bd26b).

Current head e7bd26b differs from pull request most recent head 23f6eb5

Please upload reports for the commit 23f6eb5 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10747   +/-   ##
=======================================
  Coverage   38.74%   38.74%           
=======================================
  Files         176      176           
  Lines       27887    27887           
  Branches     1217     1223    +6     
=======================================
  Hits        10804    10804           
  Misses      17083    17083           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 merged commit 1d49e47 into nextauthjs:main May 19, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants