enable static specification of node-options #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipobscure
force-pushed
the
nodeopts
branch
7 times, most recently
from
4204a1b
to
f161e73
Compare
|
Can't you just pass these in with Something like this: Edit: don't know if this is the case but there still could be a usecase for runtime variables which don't require recompiling Node |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is intended to implement passing compile-time
NODE_OPTIONSto node. I am using this to pass--experimental-vm-modules --no-warningsto a project of mine.Which issue(s) this PR fixes:
Fixes #616
Special notes for your reviewer:
At this point I just want to know whether this is the right approach in your eyes. If it is, I'll go through and clean this up and make sure it works against a set of node-versions of your choice. Right now I did this against node 17.3.0 and haven't validated against any other version.