GitHub actions asset build #1078
Conversation
bruce-one
force-pushed
the
github-actions-asset-build
branch
4 times, most recently
from
b5bfeaa
to
5e88966
Compare
bruce-one
force-pushed
the
github-actions-asset-build
branch
15 times, most recently
from
9ce8850
to
361a8c5
Compare
bruce-one
changed the title
.github/workflows/build-asset.yml
Outdated
| name: integration-tests-musl-${{ matrix.os }}-${{ env.NODEJS_VERSION }}${{ env.EXECUTABLE_SUFFIX }} | ||
| path: integration-tests | ||
| if-no-files-found: error | ||
| - if: startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
This was just a guess at a plan for how to handle this :-) Similar for the defaulting to prerelease below too :-)
bruce-one
force-pushed
the
github-actions-asset-build
branch
4 times, most recently
from
86fd91f
to
3f311a9
Compare
| with: | ||
| fail_on_unmatched_files: true | ||
| prerelease: true | ||
| files: ${{ env.NEXE_ASSET }} |
There was a problem hiding this comment.
TODO: The name of this file probably doesn't match the existing pattern
|
As a thought, would be keen to get this landed (if it looks okay, etc :-) ) before then following up with a PR to use the assets, rather than trying to get it all together in one PR :-) Partly to help keep the PRs (and effort) smaller and more manageable, but also to get the test coverage in asap :-) Knowing about Node.js versions failing is really nice :-) |
bruce-one
force-pushed
the
github-actions-asset-build
branch
from
3f311a9
to
ab96768
Compare
| @@ -1,73 +0,0 @@ | |||
| schedules: | |||
There was a problem hiding this comment.
Thanks for starting this! Originally actions didn't work because of the timeout so I had used azure pipelines. This will be so much better.
bruce-one
force-pushed
the
github-actions-asset-build
branch
3 times, most recently
from
18ceea4
to
a570eff
Compare
On macOS the temp path is a symlink and this was making the `/snapshot` resolution (`this.root` vs `/snapshot` in the zipFs) not work properly. This feels a bit like a workaround, but the path being different to the executable was the culprit in the tests not working - and that's manual code in the integration test script, and due to the custom entrypoint for Mochs, so don't think it is a workaround :-)
This shouldn't make the test execution fail. It seems to popup occasionally for some Windows removal racing, or similar.
bruce-one
force-pushed
the
github-actions-asset-build
branch
from
a570eff
to
daff50d
Compare
What this PR does / why we need it:
Adding GitHub actions build for creating the nexe asset, and also using it with the integration tests to ensure it works.
Such that people don't need to do
--buildall the time :-)Work in progress :-)
Also, this showed that Node 18.19.0 seems to be broken, and have a fix for that (in theory), so will split that off at some point :-)