Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate names for options #86

Merged
merged 5 commits into from
May 27, 2024
Merged

Conversation

abhijitb
Copy link
Contributor

@abhijitb abhijitb commented May 14, 2024

Proposed changes

In the AI site generation interface we will keep showing "Version 1", "Version 2", etc. but when the theme name and slug are generated we will use title + number like: "bean-there-cafe-3" and "Bean There Cafe 3".
If the user has chosen a name for a version we use that as title and slug for theme.
Note: This works only for favorited versions in the interface
Sone examples :

User chosen title
Before :
slug : version-3 => title : final-version
After :
slug : version-3 => title : final version

Default case 1
Before :
slug : version-1 => title : version-1
After :
slug : bean-there-cafe-1 => title : Bean There Cafe 1

Default Case 2
Before :
slug : version-1-copy-copy => title : version 1 (copy) (copy)
After :
slug : bean-there-cafe-1-copy-copy => title : Bean There Cafe 1 copy copy

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@abhijitb abhijitb added the Code Review Code Review label May 14, 2024
@officiallygod
Copy link
Member

Rest looks good, Need Intensive QA on this with all cases too.

Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good for QA

@abhijitb abhijitb added QA Ready for QA and removed Code Review Code Review labels May 22, 2024
@arunshenoy99 arunshenoy99 added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels May 24, 2024
@arunshenoy99 arunshenoy99 merged commit 8182882 into main May 27, 2024
2 checks passed
@arunshenoy99 arunshenoy99 deleted the add/generate-names-for-options branch May 27, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants