Surface errors in generate_site_meta if they happen #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,7 +117,7 @@ public static function instantiate_site_meta( $site_info, $identifier, $skip_cac | |||
| // Handle the error case by returning a WP_Error. | |||
| return new \WP_Error( | |||
| 'nfd_onboarding_error', | |||
| __( 'Error generating site meta: ', 'wp-module-onboarding' ) . $identifier, | |||
| __( 'Error generating site meta: ', 'wp-module-onboarding' ) . $identifier . ' ' . $response['error'], | |||
There was a problem hiding this comment.
The Sitegen class also returns an array sometimes for the same object $response['error'] and sometimes a String, Need to find a better way else we might still be not able to surface the errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing issues with
message: "Error generating site meta: siteclassification". This doesn't fix it, but at least surfaces a more descriptive error.