Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Update submodule commit and remove cnp imports where possible #249

Merged
merged 13 commits into from
Apr 9, 2024

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Apr 2, 2024

Updates scikit-tree wrt scikit-learn fork

Changes proposed in this pull request:

cc: @sampan501 @SUKI-O this may be useful for reviewing so you understand what Cython changes are happening

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.04%. Comparing base (f957cdb) to head (3479b8e).

Files Patch % Lines
sktree/tree/_multiview.py 86.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   90.05%   90.04%   -0.02%     
==========================================
  Files          54       54              
  Lines        5050     5105      +55     
==========================================
+ Hits         4548     4597      +49     
- Misses        502      508       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc error and failing on AMD machines?

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 requested a review from PSSF23 April 3, 2024 03:44
@adam2392
Copy link
Collaborator Author

adam2392 commented Apr 4, 2024

Doc error and failing on AMD machines?

It should be fixed now

@adam2392 adam2392 merged commit 232747e into main Apr 9, 2024
28 of 30 checks passed
@adam2392 adam2392 deleted the submodule branch April 9, 2024 01:59
@adam2392 adam2392 mentioned this pull request Apr 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants