Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Adding meson compiler directives #242

Merged
merged 8 commits into from
Mar 13, 2024
Merged

MAINT Adding meson compiler directives #242

merged 8 commits into from
Mar 13, 2024

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Mar 11, 2024

possibly related: #226

Changes proposed in this pull request:

  • The changes in the Cython code are to update to the latest commit ID in the submodule

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 requested a review from sampan501 March 11, 2024 21:44
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (8ceada5) to head (1aebc3c).
Report is 3 commits behind head on main.

❗ Current head 1aebc3c differs from pull request most recent head d3f36eb. Consider uploading reports for the commit d3f36eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   89.94%   90.06%   +0.12%     
==========================================
  Files          54       54              
  Lines        5050     5051       +1     
==========================================
+ Hits         4542     4549       +7     
+ Misses        508      502       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Member

@sampan501 sampan501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending green CIs

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 2de069e into main Mar 13, 2024
28 checks passed
@adam2392 adam2392 deleted the cython branch March 13, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants