Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Datasets based on Marron and Wand, Trunk, etc. #185

Closed
wants to merge 7 commits into from

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Dec 6, 2023

Addresses one of #197

Changes proposed in this pull request:

  • Introduce some cosmetic fixes and tests
  • Mainly adds a set of functions to generate data according to Marron and Wand 1992

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have

Here are the visual unit-tests of the proposed trunk-classification generator API

image (2)
passed.
image
image (1)

Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06a7066) 90.18% compared to head (e00e810) 90.18%.
Report is 4 commits behind head on main.

❗ Current head e00e810 differs from pull request most recent head be587b6. Consider uploading reports for the commit be587b6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          49       49           
  Lines        4198     4198           
=======================================
  Hits         3786     3786           
  Misses        412      412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 changed the title [PAPER] Adding notebook for cancer figure [ENH] Datasets based on Marron and Wand Jan 10, 2024
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 changed the title [ENH] Datasets based on Marron and Wand [ENH] Datasets based on Marron and Wand, Trunk, etc. Jan 17, 2024
@adam2392
Copy link
Collaborator Author

This is very messy, but the main thing we want to merge is make_trunk_classification to have a consistent API for generating the data

@adam2392
Copy link
Collaborator Author

Closed by #203

@adam2392 adam2392 closed this Feb 16, 2024
@adam2392 adam2392 deleted the figures branch February 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant